Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove network calls from tests #204

Closed
wants to merge 136 commits into from

Conversation

camirmas
Copy link
Collaborator

resolves #152

nRiccobo and others added 30 commits February 17, 2023 10:21
…section/equations used or repurposed from this analysis.
… variable names to match Orbit Nomenclature in yamls in .py
…modules.

pushed along to the point that green_steel_ammonia_define_scenarios.py
runs.
cfrontin and others added 28 commits August 4, 2023 11:43
reconciliation between ckiefer and cfrontin changes
Added and changed some files to get green steel code to work
* Remove redundant resource files

* Fix clustering tests

* Remove unneeded tests

We determined in our last Refactor meeting that these are not real tests and should be removed.

* Limit shapely version

There's currently a range of shapely versions that work for HOPP, and this is reflected in `master`. If we want to loosen this constraint, we'll need to figure out why the tests fail on current versions of the package.

* Fix test_csp imports

* Revert PySAM to 3.0.0

This change broke tests in tests/hopp/test_hybrid, I'm not sure why, but we'll need to revisit if we want to upgrade.

* Fix documentation build

* Disable test_pressure_vessel

* Fix test_custom_financial

* Reorganize tests into tests/hopp

* Disable analysis tests

Met with Kaitlin Brunik (@kbrunik) today to discuss these particular analysis tests. These are based on outdated examples, and need to be re-assessed alongside the code in the holdover `to_organize` directory, which contains a number of files that likely belong as project code rather than usage examples for the repository.

* Update Custom Financial Model (NREL#195)

* pull in changes from pysam_update_capacity

* fix import

* update tests

* undo a commenting

* BatteryStateless (NREL#196)

* pull in changes from pysam_update_capacity

* fix import

* update tests

* add batttery_stateless

* break out create_max_gross_profit_objective by tech

* fix tests

* fix minor comments

* update .gitignore

* Remove more resource files

Another attempt at removing files that are not explicitly used in the code.

* Re-add clobbered changes and fix imports

---------

Co-authored-by: Darice L Guittet <[email protected]>
Co-authored-by: Jared Thomas <[email protected]>
Everything works the same, but now users will need to specify `wind=False` or `solar=False` in the initialization of `SiteInfo`, rather than modifying the data dictionary with `no_wind` or `no_solar`.
This update removes network calls wherever they exist, and also adds new unit tests for functionality related to API calls.
@camirmas camirmas closed this Aug 24, 2023
@camirmas camirmas deleted the resource-tests branch August 24, 2023 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants